Fix #2205, Enforce strict cast alignment on arch #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
2 tasks
|
cFE and workflows need to use Ubuntu 20.04 at minimum for this flag to work: Error w/o dependency can be seen here: |
dzbaker
added
CCB:Approved
dzbaker
added a commit
that referenced
this pull request
Nov 23, 2022
Fix #2205, Enforce strict cast alignment on arch
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 23, 2022
*Combines:* osal v6.0.0-rc4+dev165 cFE v7.0.0-rc4+dev215 sample_lib v1.3.0-rc4+dev32 **Includes:** *osal* - nasa/osal#1334 *cFE* - nasa/cFE#2209 - nasa/cFE#2206 - nasa/cFE#2204 - nasa/cFE#2203 *sample_lib* - nasa/sample_lib#92 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
This was referenced Nov 23, 2022
The -Wcast-align=strict option only works with certain versions of gcc. This moves it to the "native" custom options, so it will not be used on cross builds.
|
@jphickey that's a good fix... did you want to separate out the other non clang flags also? |
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 28, 2022
*Combines:* osal v6.0.0-rc4+dev165 cFE v7.0.0-rc4+dev218 sample_lib v1.3.0-rc4+dev32 **Includes:** *osal* - nasa/osal#1334 *cFE* - nasa/cFE#2209 - nasa/cFE#2206 - nasa/cFE#2204 - nasa/cFE#2203 *sample_lib* - nasa/sample_lib#92 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 28, 2022
*Combines:* osal v6.0.0-rc4+dev165 cFE v7.0.0-rc4+dev218 sample_lib v1.3.0-rc4+dev32 **Includes:** *osal* - nasa/osal#1334 *cFE* - nasa/cFE#2209 - nasa/cFE#2206 - nasa/cFE#2204 - nasa/cFE#2203 *sample_lib* - nasa/sample_lib#92 Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
CI
Expected behavior changes
None, just enforces strict alignment and currently compliant
System(s) tested on
CI
Additional context
Note this strict option isn't supported by clang so would need to be removed along with
-Wno-format-truncationand-Wno-stringop-truncationThird party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC